Re: [PATCH 2/2] SoC: dt-bindings: asahi-kasei,ak4619: Add PDN GPIO support

[Alexander Koch]

> > Add documentation for optional property that enables operation of the
> > 'PDN' pin during initialization:
> >
> >      codec@10 {
> >          compatible = "asahi-kasei,ak4619";
> >          reg = <0x10>;
> >          pdn-gpios = <&gpio1 0 GPIO_ACTIVE_HIGH>;  // <--
> >          #sound-dai-cells = <0>;
> >      };
> >
> > Signed-off-by: Alexander Koch <mail@xxxxxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/sound/asahi-kasei,ak4619.yaml     | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4619.yaml b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4619.yaml
> > index d412531ef9a2..3c7754351e8a 100644
> > --- a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4619.yaml
> > +++ b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4619.yaml
> > @@ -34,6 +34,12 @@ properties:
> >       $ref: audio-graph-port.yaml#
> >       unevaluatedProperties: false
> >   
> > +  pdn-gpios:
> powerdown-gpios is a standard name for this function.

Thanks for the hint, this might actually inverse the logical polarity of 
the GPIO that I had in mind. I will look at other examples and consider 
them when submitting v2.

> > +    maxItems: 1
> > +    description:
> > +      GPIO controlling the AK4619 PDN input pin. Used during driver
> > +      probing to power up the codec.
> When a driver does something is not relevant. Would be useful to state
> the active (meaning powered down state based on the naming) state.

Understood, I will make that more clear in v2.


Best regards,

Alex