RE: [PATCH v2] pinctrl: realtek: rtd1619b: publish the OF module alias

From: Yu-Chun Lin [林祐君]

Date: Mon Sep 28 2026 - 11:03:29 EST


> PINCTRL_RTD1619B is tristate, and the driver uses the realtek,rtd1619b-pinctrl
> compatible to match its devices. However, the OF table is not exported, so a
> modular build does not advertise this alias for automatic module loading.
>
> Add the OF export without changing probe or registration ordering.
>
> The issue was found by our static-analysis tool.
>
> Fixes: c7910f6aca56 ("pinctrl: realtek: Add pinctrl driver for RTD1619B")
> Assisted-by: gpt 5
> Signed-off-by: Pengpeng Hou <hppiscas@xxxxxxx>

Acked-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>

> ---
> Changes since v1:
> https://lore.kernel.org/all/20260905134418.67619-1-hppiscas@xxxxxxx/
> Use the full author name and regenerate the plain-text inline diff without
> embedded carriage returns.
>
> drivers/pinctrl/realtek/pinctrl-rtd1619b.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> b/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> index b07e50d6356d..e03e1fb09899 100644
> --- a/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> +++ b/drivers/pinctrl/realtek/pinctrl-rtd1619b.c
> @@ -1575,6 +1575,7 @@ static const struct of_device_id
> rtd1619b_pinctrl_of_match[] = {
> { .compatible = "realtek,rtd1619b-pinctrl", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, rtd1619b_pinctrl_of_match);
>
> static struct platform_driver rtd1619b_pinctrl_driver = {
> .driver = {
>
> base-commit: 518e5b794c06c0f0eb40df3e202274a66202c137
> --
> 2.50.1 (Apple Git-155)