Re: [PATCH] dmaengine: fsl_raid: use !desc for NULL check

From: Frank Li

Date: Mon Sep 28 2026 - 12:56:45 EST


On Sun, Sep 27, 2026 at 01:52:24PM -0700, Rosen Penev wrote:
> <= 0 is flagged by sparse as being used for integer, not pointer
> comparison. Fix the warning.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

> drivers/dma/fsl_raid.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
> index 9cc289f7129e..8e7026682d0a 100644
> --- a/drivers/dma/fsl_raid.c
> +++ b/drivers/dma/fsl_raid.c
> @@ -346,7 +346,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_genq(
> }
>
> desc = fsl_re_chan_alloc_desc(re_chan, flags);
> - if (desc <= 0)
> + if (!desc)
> return NULL;
>
> if (scf && (flags & DMA_PREP_CONTINUE)) {
> @@ -470,7 +470,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_pq(
> src_cnt += 3;
>
> desc = fsl_re_chan_alloc_desc(re_chan, flags);
> - if (desc <= 0)
> + if (!desc)
> return NULL;
>
> /* Filling GenQQ CDB */
> @@ -554,7 +554,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_memcpy(
> }
>
> desc = fsl_re_chan_alloc_desc(re_chan, flags);
> - if (desc <= 0)
> + if (!desc)
> return NULL;
>
> /* Filling move CDB */
> --
> 2.55.0
>