Re: [PATCH v5 1/6] x86/tdx: Take the Quote buffer as a generic pointer

[Peter Fang]

On Mon, Sep 28, 2026 at 12:04:30PM -0700, Edgecombe, Rick P wrote:
> On Mon, 2026-09-28 at 03:08 -0700, Peter Fang wrote:
> > tdx_hcall_get_quote() takes a "u8 *" buffer unnecessarily. It is never
> > used as such, since only the buffer's memory address matters. Let the
> > guest driver give the buffer a type internally and just accept it as a
> > "void *" instead.
> > 
> > AI was used under supervision to collect/apply feedback, review code and
> > workshop logs.
> > 
> > Signed-off-by: Peter Fang <peter.fang@xxxxxxxxx>
> > ---
> > v5:
> >  - New patch. Prepare for a typed Quote buffer. [Dave]
> 
> I guess this traces back to a comment by Binbin. Which had a specific reason.
> Changing the global from a void * means a cast would be needed to pass it to
> tdx_hcall_get_quote(). I had to go hunting back multiple versions to learn this
> because the log didn't mention it. Otherwise it looks like misc cleanup. Can you
> explain the connection to future changes in the log?

Thanks for pointing this out. Yeah some of the review history got lost
in the shuffle. I'll document better in the next version.