Re: [PATCH RFC] gpio: move intel drivers into their own directory

From: Sakari Ailus

Date: Mon Sep 28 2026 - 17:22:24 EST


Hi Andy,

On Mon, Sep 28, 2026 at 04:10:41PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 28, 2026 at 3:35 PM Hans de Goede <hansg@xxxxxxxxxx> wrote:
> > On 28-Sep-26 13:34, Andy Shevchenko wrote:
> > > On Mon, Sep 28, 2026 at 2:13 PM Bartosz Golaszewski <brgl@xxxxxxxxxx> wrote:
> > >> On Sat, 26 Sep 2026 12:07:27 +0200, Mika Westerberg
> > >> <mika.westerberg@xxxxxxxxxxxxxxx> said:
> > >>> On Fri, Sep 25, 2026 at 05:34:53PM +0300, Andy Shevchenko wrote:
> > >>>> On Fri, Sep 25, 2026 at 02:54:33PM +0200, Mika Westerberg wrote:
> > >>>>> On Fri, Sep 25, 2026 at 01:48:05PM +0300, Andy Shevchenko wrote:
> > >>>>>> On Fri, Sep 25, 2026 at 12:22:15PM +0200, Bartosz Golaszewski wrote:
>
> ...
>
> > >>>>>>> drivers/gpio/{ => intel}/gpio-graniterapids.c | 0
> > >>>>>>> drivers/gpio/{ => intel}/gpio-novalake-events.c | 0
> > >>>>>>
> > >>>>>> These are interesting drivers, not sure where to put them
> > >>>>>
> > >>>>> IMHO they should be there too. We are maintaining them both.
> > >>>>
> > >>>> Do you send PRs to Bart or you just rely on him to take the patches?
> > >>>
> > >>> I don't expect these two drives to get too much attention, and they could
> > >>> be contained nicely inside intel folder and that would help Bart to
> > >>> identify that these are Intel drivers. So your bandwidth would not suffer
> > >>> even if these two are added there. Your call.
> > >>
> > >> I'd like to avoid a situation where we have Andy's Intel drivers under
> > >> drivers/gpio/intel/ and other Intel drivers under drivers/gpio/. I'd prefer
> > >> to move all of intel GPIO drivers into drivers/gpio/intel/ and have Andy
> > >> gather changes to them if he agrees.
> > >
> > > Okay, we have two parts missing:
> > > - Nova Lake driver (I would need Adam or Mika to step in as at least a
> > > designated reviewer for that)
> > > - USB IO (I think we need to agree which tree it will go through, my
> > > bet that media tree is the best), for that we need Hans' consent
> >
> > Routing the USBIO / LCJA GPIO drivers to the media-tree, with
> > Sakari likely doing the merging for both works for me.
>
> Sure, Sakari, would it work for you?

Yes.

That being said, the USBIO driver(s) come in three parts, this one (GPIO),
I²C and the main USB USBIO driver. Patches (or at least the set they're in)
often touch more than one and then they're routed through the USB tree in
practice. It'd be practical all would be merged via the media tree, unless
there are dependencies to other parts of the respective tree.

Perhaps we should still do this to GPIO first and then think about the
rest.

Also cc Miguel.

--
Kind regards,

Sakari Ailus