Re: [PATCH 1/5] perf test demangle: Fail when demangling fails

[Ian Rogers]

On Sun, Sep 27, 2026 at 6:02 PM Michal Pluta <michalpl2003@xxxxxxxxx> wrote:
>
> The Rust and Java demangle tests only log a NULL result from
> dso__demangle_sym() and carry on, so a symbol that fails to demangle
> doesn't fail the test.  Set TEST_FAIL.
>
> Assisted-by: LLM
> Signed-off-by: Michal Pluta <michalpl2003@xxxxxxxxx>

Fixes: 07f2b1287c97 ("perf test demangle-java: Don't segv if demangling fails")
Fixes: bdf05ccd1841 ("perf test demangle-rust: Add Rust demangling test")

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks!
Ian

> ---
>  tools/perf/tests/demangle-java-test.c    | 1 +
>  tools/perf/tests/demangle-rust-v0-test.c | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/tools/perf/tests/demangle-java-test.c b/tools/perf/tests/demangle-java-test.c
> index 0fb3e5a4a0ed..a8eb0f4effad 100644
> --- a/tools/perf/tests/demangle-java-test.c
> +++ b/tools/perf/tests/demangle-java-test.c
> @@ -33,6 +33,7 @@ static int test__demangle_java(struct test_suite *test __maybe_unused, int subte
>                 if (!buf) {
>                         pr_debug("FAILED to demangle: \"%s\"\n \"%s\"\n", test_cases[i].mangled,
>                                  test_cases[i].demangled);
> +                       ret = TEST_FAIL;
>                         continue;
>                 }
>                 if (strcmp(buf, test_cases[i].demangled)) {
> diff --git a/tools/perf/tests/demangle-rust-v0-test.c b/tools/perf/tests/demangle-rust-v0-test.c
> index 904f966c65d7..ee4ddb61174b 100644
> --- a/tools/perf/tests/demangle-rust-v0-test.c
> +++ b/tools/perf/tests/demangle-rust-v0-test.c
> @@ -58,6 +58,7 @@ static int test__demangle_rust(struct test_suite *test __maybe_unused, int subte
>                 if (!buf) {
>                         pr_debug("FAILED to demangle: \"%s\"\n \"%s\"\n", test_cases[i].mangled,
>                                  test_cases[i].demangled);
> +                       ret = TEST_FAIL;
>                         continue;
>                 }
>                 if (strcmp(buf, test_cases[i].demangled)) {
> --
> 2.43.0
>