Re: [PATCH v13 00/25] Allow AET to use PMT as loadable module
From: Luck, Tony
Date: Mon Sep 28 2026 - 20:32:32 EST
Sashiko summary (full version: https://sashiko.dev/#/patchset/20260928221509.68002-1-tony.luck%40intel.com)
Patch 4: [PATCH v13 04/25] x86/resctrl: Centralize monitoring feature enumeration
Sashiko thinks I broke AMD & Hygon by adding the dependency:
{ X86_FEATURE_CQM_LLC, X86_FEATURE_CQM }
and this code:
> + /* Any monitoring at all? */
> + if (!cpu_feature_enabled(X86_FEATURE_CQM))
> + return false;
But Babu said he tested v12 which had this same change. So perhaps bogus?
Patch 21: [PATCH v13 21/25] x86/resctrl: Export interface to report telemetry unbind/remove
Sashiko says my new locks still have races. This one looks real. See below(*).
But also a bogus warning that intel_aet_read_event() may be called from
IPI handler on nohz CPUs. All AET events are read from MMIO, so can be
accessed on any CPU, so there is never an smp_call_*() via IPI.
Patch 22: [PATCH v13 22/25] platform/x86/intel/pmt: Inform resctrl when MMIO maps are being removed
Bogus concern about ACPI telemetry devices. They don't exist.
---
* I asked another AI if it could fix my locking issue. It's given me some
slightly complicated code that has some scoped_guard() bits to hold and
release locks. I'm staring at it now to see if I like it.
-Tony