Re: [PATCH net-next v21 1/3] dt-bindings: net: Document Motorcomm YT8824 PHY package

From: Kyle Switch

Date: Mon Sep 28 2026 - 20:50:07 EST



On 9/29/26 00:25, Conor Dooley wrote:
On Mon, Sep 28, 2026 at 09:43:48AM +0800, Kyle Switch wrote:

+unevaluatedProperties: false
+
+examples:
+ - |
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet-phy-package@9 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "motorcomm,yt8824-package";
+ reg = <9>;
+
+ phy-mode = "internal";
+
+ ethernet-phy@4 {
+ reg = <4>;
+ };
+
+ ethernet-phy@5 {
+ reg = <5>;
+ };
+
+ ethernet-phy@6 {
+ reg = <6>;
+ };
+
+ ethernet-phy@7 {
+ reg = <7>;
+ };
Unless the addresses and numbers of phys are entirely unconstrained, I
think you should add some pattern properties for them.
Ans: I'm somewhat confused on this point. What might the pattern properties
There's no need for this "ans" business, the quoting makes it clear
already.
okay, thank you.
        you mentioned include? Could you provide more detail? thank you.
On second thoughts, there's some basic constraints already provided by
ethernet-phy-package for this. Probably don't need to anyhting specific.

okay, based on your suggestions, the next version will be modified.