Re: [PATCH v2] writeback: let foreign flushes reach dying cgwbs
From: Liz Fong-Jones
Date: Mon Sep 28 2026 - 21:47:04 EST
Hi Andrew,
On Mon, 28 Sep 2026 16:56:12 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> IMO the above two paragraphs are the most important part of the patch
> description yet they're in the throw-away section. They should be right at
> the start of everything. Thanks for at least including them - many do not.
Thank you, I'm honoured you took a look. You're right, and that's my
mistake: I was used to commit messages leading with what the patch does,
to help maintainers judge the risk, rather than why, to show the
benefit. v3 moves the problem and its trigger to the start of the
changelog:
https://lore.kernel.org/all/20260928-wb-dying-cgwb-flush-v3-0-e35374884667@xxxxxxxxxxxx/
It might also help to say this in Documentation/process/coding-assistants.rst.
Its step 6 asks for "a detailed message describing the problem, the
solution and a Fixes tag". If it pointed to "Describe your problem" and
"Describe user-visible impact" in submitting-patches.rst, assistants
like the one I used would likely lead with the benefit on their own.
Thanks,
Liz