Re: [PATCH v3 27/40] mm: remove hugetlb_inline.h

[Zi Yan]

On Thu Sep 17, 2026 at 12:22 PM EDT, Lorenzo Stoakes (ARM) wrote:
> This header really makes little sense - every place it is included mm.h is
> also included, and the header itself includes mm.h, so it does nothing to
> reduce header size.
>
> It also oddly does an #ifdef around checking VMA_HUGETLB_BIT, however
> VMA_HUGETLB_BIT is unconditionally available, and will never be set if
> hugetlb is not enabled.
>
> Simply remove the header, eliminate the odd ifdeffery and place the
> predicates in mm.h.
>
> The naming of these predicates is odd, but to keep changes separate, we
> will address this in a separate patch.
>
> The file was never put into MAINTAINERS so there's no change required
> there.
>
> No functional change intended.
>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/drm_gpusvm.c   |  2 +-
>  include/asm-generic/tlb.h      |  2 +-
>  include/linux/hugetlb.h        |  1 -
>  include/linux/hugetlb_inline.h | 28 ----------------------------
>  include/linux/mm.h             | 11 +++++++++++
>  include/linux/pagemap.h        |  1 -
>  include/linux/userfaultfd_k.h  |  1 -
>  kernel/sched/fair.c            |  1 -
>  mm/vma_internal.h              |  1 -
>  9 files changed, 13 insertions(+), 35 deletions(-)
>
Makes sense.

Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>

-- 
Best Regards,
Yan, Zi