Re: [PATCH net v3 2/2] net: ethtool: let tsconfig reach a PHY-only timestamp provider

From: Jakub Kicinski

Date: Mon Sep 28 2026 - 22:34:44 EST


On Sat, 26 Sep 2026 20:03:14 +0200 Maxime Chevallier wrote:
> > There is no in-tree driver with ndo_hwtstamp_set but not _get. All 73 files
> > have them in pairs...
> >
> > Even further, the asymmetry is on purpose. The get side tests ndo_hwtstamp_get
> > and the set side tests ndo_hwtstamp_set, each gate testing what its own operation
> > needs.
> >
> > If anyone insists on the symmetry, a v4 could add || !ndo_hwtstamp_get. But before
> > I respin again, let's hear if this is really needed.
>
> The current way LGTM :)

Alright, but let's also follow up on this and add a check somewhere
during netdev registration to reject the asymmetric ops.