Re: [PATCH v3 net-next] octeontx2-af: pass devlink switch id and cache representor map

[Ratheesh Kannoth]

On 2026-09-28 at 14:08:54, netdev-bot+sashiko@xxxxxxxxxx (netdev-bot+sashiko@xxxxxxxxxx) wrote:
> Thank you for your contribution! Sashiko AI review found 7 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 (4) · Medium: 6 (3) · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] Turning off the eswitch now makes the AF forget the
>   representor PF before that PF has freed its hardware resources.
> - [Medium] struct esw_cfg_req grows from 32 bytes to 72 bytes:
>   switch_id[MAX_PHYS_ITEM_ID_LEN] and switch_id_len are appended after…
> - [Medium] The new call to rvu_rep_cache_reset() in __rvu_flr_handler()
>   sets rep_mode = 0 when the representor PF goes through FLR.
> - [Medium] The patch puts rep_pcifunc, rep_mode,
>   rswitch.switch_id/switch_id_len, rep_cnt and rep2pfvf_map under…
> - [Medium] Before this patch, rep_pcifunc was only ever set.
> - [Medium] rvu_mbox_handler_esw_cfg() reads req->switch_id_len from the
>   shared mailbox several times: once for the bounds check, once as the…
> - [Low] The switch-id plumbing the commit message describes has no
>   consumer.

ACK.

pw-bot: changes-requested