Re: [PATCH v2] KVM: x86: Clear hardware HLT state when userspace makes a vCPU not-halted

[Keqiang Duan]

> Anyways, unless someone cares enough to want to back up the claim that spurious
> wakeups are ok, I'll just drop that line when applying.  I don't see any reason
> to mention spurious wakes: the vCPU is clearly being moved out of HALTED state,
> it's on userspace not to screw up (for this particular case; there are other live
> migration issues that userspace can't solve).

You're right, I was conflating the software convention (every HLT is
inside a loop) with
an architectural guarantee.  The SDM and APM are clear on what
actually wakes HLT,
and neither mentions spurious wakeups.

Please go ahead and drop that line.  Thanks for catching it.