Re: [PATCH 1/3] dt-bindings: i2c: add Amlogic A9 I2C controller

[Xianwei Zhao]

Hi Conor,
   Thanks for your review.

On 2026/9/25 01:01, Conor Dooley wrote:
> Subject:
> Re: [PATCH 1/3] dt-bindings: i2c: add Amlogic A9 I2C controller
> From:
> Conor Dooley <conor@xxxxxxxxxx>
> Date:
> 2026/9/25 01:01
>
> To:
> xianwei.zhao@xxxxxxxxxxx
> CC:
> Junyi Zhao <junyi.zhao@xxxxxxxxxxx>, Andi Shyti <andi.shyti@xxxxxxxxxx>, 
> Rob Herring <robh@xxxxxxxxxx>, Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>, 
> Conor Dooley <conor+dt@xxxxxxxxxx>, Xianwei Zhao 
> <xianwei.zhaol@xxxxxxxxxxx>, Junyi Zhao <junyi.zhaol@xxxxxxxxxxx>, 
> linux-i2c@xxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, 
> devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
>
>
> On Thu, Sep 24, 2026 at 08:39:34AM +0000, Xianwei Zhao via B4 Relay wrote:
> > From: Xianwei Zhao<xianwei.zhao@xxxxxxxxxxx>
> >
> > Add a Device Tree binding for the I2C controller found on the
> > Amlogic A9 SoC.
> >
> > Signed-off-by: Xianwei Zhao<xianwei.zhao@xxxxxxxxxxx>
> Since this is not in the existing meson file, does that mean that
> there's a substantial change in the IP design, other than the addition
> of dma support?

Yes. This is a new I2C controller that is different from the existing one.

> > ---
> >   .../devicetree/bindings/i2c/amlogic,a9-i2c.yaml    | 61 ++++++++++++++++++++++
> >   1 file changed, 61 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/amlogic,a9-i2c.yaml b/Documentation/devicetree/bindings/i2c/amlogic,a9-i2c.yaml
> > new file mode 100644
> > index 000000000000..681241a52680
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/i2c/amlogic,a9-i2c.yaml
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:http://devicetree.org/schemas/i2c/amlogic,a9-i2c.yaml#
> > +$schema:http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Amlogic A9 I2C Controller
> > +
> > +maintainers:
> > +  - Xianwei Zhao<xianwei.zhaol@xxxxxxxxxxx>
> > +  - Junyi Zhao<junyi.zhaol@xxxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: /schemas/i2c/i2c-controller.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: amlogic,a9-i2c
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  dmas:
> > +    items:
> > +      - description: DMA controller phandle and request line for RX
> > +      - description: DMA controller phandle and request line for TX
> > +
> > +  dma-names:
> > +    items:
> > +      - const: rx
> > +      - const: tx
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c@3a4400 {
> > +        compatible = "amlogic,a9-i2c";
> > +        reg = <0x3a4400 0x3c>;
> > +        interrupts = <1 164 1>;
> > +        clocks = <&clkc_periphs 11>;
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        eeprom@52 {
> > +            compatible = "atmel,24c32";
> > +            reg = <0x52>;
> > +        };
> Remove this from your example please.

Will remove eeprom node from examples.

> pw-bot: changes-requested
>
> Thanks,
> Conor.
>
> > +    };
> >
> > --
> > 2.52.0