Re: [PATCH v4 1/3] scripts: add TOML config to container tool
From: Guillaume Tucker
Date: Tue Sep 29 2026 - 03:09:15 EST
Hi Nathan,
On 18/09/2026 11:48 pm, Nathan Chancellor wrote:
Hi Guillaume,
On Fri, Sep 18, 2026 at 12:04:09PM +0200, Guillaume Tucker wrote:
On 07/09/2026 13:10, Guillaume Tucker wrote:
Add support for a TOML configuration file to the scripts/containerThanks for the reviews so far.
tool. This improves user experience by not having to keep passing the
same command line options all the time or overly relying on built-in
default values. Include the concept of 'profiles' with different
named sections in the file to cover various use cases.
Command line options take precedence over the config file, and values
defined in profile sections take precedence over the default one.
Add a -c option to override the location of the .container.toml config
file which should otherwise be located in the current working
directory. If not found, the file is silently ignored as it is not
strictly required unless the -c option is used.
Add a -p option to choose a particular profile section in the config
file rather than the default.
Signed-off-by: Guillaume Tucker <gtucker@xxxxxxxxxx>
Acked-by: Nicolas Schier <n.schier@xxxxxxxxx>
---
Notes:
Changes in v2:
- fix uid / gid handling when set to 0 (root)
Changes in v3:
- fix logic when loading config profiles using None
- fix typo with missing whitespace in help message
- clarify how UID gets used as default value for GID
Changes in v4:
- drop registry option from TOML config
scripts/container | 86 ++++++++++++++++++++++++++++++++++++++++-------
1 file changed, 74 insertions(+), 12 deletions(-)
Do you guys need anything else regarding this series?
There's no rush of course and we're all busy, just making sure I
didn't miss anything.
No, my apologies for not responding to this sooner. I plan to take a
look soon, I just keep getting preeempted by other stuff.
Sure, no worries. On a related topic, I also just started a new
thread about hosting container images[1]. And I'll be at Plumbers
next week so we may also catch up there and discuss next steps etc.
Best wishes,
Guillaume
[1] https://lore.kernel.org/all/01a87de4-8de5-4ff0-941b-2e5932a3a19c@xxxxxxxxxx/