Re: [PATCH v2 02/11] dt-bindings: display: panel: samsung,s6e3ha8: Add AMB630QY01 panel

[Krzysztof Kozlowski]

On Thu, Sep 24, 2026 at 04:01:30PM +0200, David Heidelberg wrote:
> The Google Pixel 3 XL (crosshatch) uses a Samsung AMB630QY01 6.3"
> 1440x2960 flexible AMOLED panel.
> 
> Assisted-by: LLM
> Signed-off-by: David Heidelberg <david@xxxxxxx>
> ---
>  .../bindings/display/panel/samsung,s6e3ha8.yaml    | 31 ++++++++++++++++++++--
>  1 file changed, 29 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml
> index ca250b1b91712..acc2ea2969298 100644
> --- a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml
> @@ -7,48 +7,75 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>  title: Samsung s6e3ha8 AMOLED DSI panel
>  
>  description: |
>    The s6e3ha8 is a display driver IC used in 1440x2960 AMOLED panels from
>    Samsung Mobile Displays (SMD).
>  
>    Known panels:
>      - AMB577PX01, 5.77", Samsung Galaxy S9 (samsung,s6e3ha8-amb577px01)
> +    - AMB630QY01, 6.3", Google Pixel 3 XL (samsung,s6e3ha8-amb630qy01)
>  
>  maintainers:
>    - Dzmitry Sankouski <dsankouski@xxxxxxxxx>
>  
>  allOf:
>    - $ref: panel-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - samsung,s6e3ha8
> +              - samsung,s6e3ha8-amb577px01
> +    then:
> +      required:
> +        - vddr-supply
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: samsung,s6e3ha8-amb630qy01
> +    then:
> +      required:
> +        - vddpos-supply
> +        - vddneg-supply

Entire allOf goes after required: block.

Best regards,
Krzysztof