Re: [PATCH] riscv: process: Use str_supported_unsupported() in compat_mode_detect()

[Geert Uytterhoeven]

Hi Paul, Thorsten,

On Sat, 26 Sept 2026 at 01:48, Paul Walmsley <pjw@xxxxxxxxxx> wrote:
> On Thu, 24 Sep 2026, Thorsten Blum wrote:
> > Replace hard-coded strings with the str_supported_unsupported() helper.
> > This unifies the output and helps the linker with deduplication, which
> > can result in a smaller binary.
> >
> > Signed-off-by: Thorsten Blum <blum@xxxxxxxxxx>
>
> Thanks, queued for v7.4.

Thanks for your patch, which is now commit a06776565b9e7351 ("riscv:
process: Use str_supported_unsupported() in compat_mode_detect()")
in riscv/for-next.

This fails to build:

    arch/riscv/kernel/process.c: In function ‘compat_mode_detect’:
    arch/riscv/kernel/process.c:138:17: error: implicit declaration of
function ‘str_supported_unsupported’
[-Werror=implicit-function-declaration]
      138 |                 str_supported_unsupported(compat_mode_supported));
          |                 ^~~~~~~~~~~~~~~~~~~~~~~~~

as it has a hard dependency on commit 5383cf280ef4f00b
("lib/string_choices: Add str_supported_unsupported()
helper"), which is only present in the for-next branch of
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds