Re: [PATCH v7 0/3] Add initial DTS for Samsung Galaxy Book4 Edge

[Antheas Kapenekakis]

On Sun, 20 Sept 2026 at 20:41, Maxim Storetvedt <mstoretv@xxxxxxx> wrote:
>
> This patch introduces devicetrees to support the hamoa Samsung Galaxy Book4
> Edge, and includes the X1E80100 14-inch SKU and X1E84100 16-inch SKU.
>
> It continues the earlier patch series started by Marcus Glocker, and the
> previously submitted v6 [1].
>
> Supported:
> - Keyboard
> - Touchpad
> - USB type-c

On the next revision, specify that USB type A is fully supported (16
in) and Type C is supported as initialized by UEFI only

> - Display

Consider fixing the Touchscreen too. If I recall the goodix driver
works as is. At least on my device. Update the dbt. You may reference
my oot dbt for this.

I will add my reviewed-by/tested-by on the final revision and that's
enough for me. You don't need to give me more credit than that.

Best,
Antheas

> - HDMI
> - WiFi
> - Bluetooth
> - ADSP / CDSP
> - GPU
> - UFS
> - Suspend
>
> Other features (such as the camera and touchscreen) are also confirmed working,
> but for now need multiple patches/changes out of scope for this submission.
> These are tracked downstream in the meantime [2].
>
> Changed from v6:
> - Updated to match current linux-next
> - Use 14 inch SKU as base for the dtsi
>
> Changed from v5:
> - Reworked DTS/DTSI for both 14- & 16-inch SKUs
> - Added Galaxy Book4 Edge to QSEECOM
> - Removed UFS node from the patch
>
> Changed from v4:
> * Fix previously missed commits:
> - Improved commit messages.
> - Added missing clock line for ufs.
> - Removed invalid microamp lines for ufs.
>
> Changed from v3:
> - Improved commit messages.
> - Added missing clock line for ufs.
> - Removed invalid microamp lines for ufs.
>
> Changed from v2:
> - Squash Makefile patch to new DTS file patch.
>
> Changed from v1:
> - Provide the patch in the expected format.
> - Added missing bindings.
> - Removed sound node.
> - Changed regulator syntax to be consistent.
> - Changed touchscreen node comment, and removed false pin definition.
> - Rename ufshc@ to ufs@.
>
> [1] https://lore.kernel.org/all/20260322160317.424797-1-mstoretv@xxxxxxx/
> [2] https://github.com/zensanp/linux-book4-edge/
>
> Maxim Storetvedt (3):
>   dt-bindings: arm: Add Samsung Galaxy Book4 Edge
>   firmware: qcom: scm: Allow QSEECOM on the Samsung Galaxy Book4 Edge
>   arm64: dts: qcom: Add hamoa Samsung Galaxy Book4 Edge devicetrees
>
>  .../devicetree/bindings/arm/qcom.yaml         |    7 +
>  arch/arm64/boot/dts/qcom/Makefile             |    2 +
>  .../qcom/x1-samsung-galaxy-book4-edge.dtsi    | 1537 +++++++++++++++++
>  .../x1e80100-samsung-galaxy-book4-edge-14.dts |   28 +
>  .../x1e84100-samsung-galaxy-book4-edge-16.dts |   31 +
>  drivers/firmware/qcom/qcom_scm.c              |    1 +
>  6 files changed, 1606 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/x1-samsung-galaxy-book4-edge.dtsi
>  create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-samsung-galaxy-book4-edge-14.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/x1e84100-samsung-galaxy-book4-edge-16.dts
>
>
> base-commit: 3f2425f5b5bbbdd991ca9cdfd5502e68d8895998
> --
> 2.43.0
>