Re: [PATCH] clocksource: publish finished_booting with release semantics

[Thomas Gleixner]

On Mon, Sep 21 2026 at 21:22, Jaidev Shastri via wrote:
> From: Jaidev Shastri <jaidevshastri@xxxxxx>
>
> clocksource_done_booting() sets curr_clocksource and then
> finished_booting, both with plain stores under clocksource_mutex.
> clocksource_find_best() tests finished_booting with a plain load before
> it walks clocksource_list.
>
> Set the flag with smp_store_release() and read it with
> smp_load_acquire().
>
> Found with MBCheck, a static herd7-based memory consistency checker.

Unfortunately your tool is missing the point. All callchains which end
up in clocksource_find_best() hold clocksource_mutex. So this
acquire/release is pointless.

Thanks,

        tglx