Re: [PATCH RFC] gpio: move intel drivers into their own directory

[Bartosz Golaszewski]

On Tue, 29 Sep 2026 14:45:59 +0200, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> said:
> On Tue, Sep 29, 2026 at 3:15 PM Alan Borzeszkowski
> <alan.borzeszkowski@xxxxxxxxxxxxxxx> wrote:
>> On Mon, 2026-09-28 at 16:13 +0300, Andy Shevchenko wrote:
>> > On Mon, Sep 28, 2026 at 3:34 PM Mika Westerberg
>> > <mika.westerberg@xxxxxxxxxxxxxxx> wrote:
>> > > On Mon, Sep 28, 2026 at 02:34:44PM +0300, Andy Shevchenko wrote:
>> > > > On Mon, Sep 28, 2026 at 2:13 PM Bartosz Golaszewski
>> > > > <brgl@xxxxxxxxxx> wrote:
>> > > > > On Sat, 26 Sep 2026 12:07:27 +0200, Mika Westerberg
>> > > > > <mika.westerberg@xxxxxxxxxxxxxxx> said:
>> > > > > > On Fri, Sep 25, 2026 at 05:34:53PM +0300, Andy Shevchenko
>> > > > > > wrote:
>> > > > > > > On Fri, Sep 25, 2026 at 02:54:33PM +0200, Mika Westerberg
>> > > > > > > wrote:
>> > > > > > > > On Fri, Sep 25, 2026 at 01:48:05PM +0300, Andy Shevchenko
>> > > > > > > > wrote:
>> > > > > > > > > On Fri, Sep 25, 2026 at 12:22:15PM +0200, Bartosz
>> > > > > > > > > Golaszewski wrote:
>
> ...
>
>> > > > > > > > > >  drivers/gpio/{ => intel}/gpio-graniterapids.c   |  0
>> > > > > > > > > >  drivers/gpio/{ => intel}/gpio-novalake-events.c |  0
>> > > > > > > > >
>> > > > > > > > > These are interesting drivers, not sure where to put
>> > > > > > > > > them
>> > > > > > > >
>> > > > > > > > IMHO they should be there too. We are maintaining them
>> > > > > > > > both.
>> > > > > > >
>> > > > > > > Do you send PRs to Bart or you just rely on him to take the
>> > > > > > > patches?
>> > > > > >
>> > > > > > I don't expect these two drives to get too much attention,
>> > > > > > and they could
>> > > > > > be contained nicely inside intel folder and that would help
>> > > > > > Bart to
>> > > > > > identify that these are Intel drivers. So your bandwidth
>> > > > > > would not suffer
>> > > > > > even if these two are added there. Your call.
>> > > > >
>> > > > > I'd like to avoid a situation where we have Andy's Intel
>> > > > > drivers under
>> > > > > drivers/gpio/intel/ and other Intel drivers under
>> > > > > drivers/gpio/. I'd prefer
>> > > > > to move all of intel GPIO drivers into drivers/gpio/intel/ and
>> > > > > have Andy
>> > > > > gather changes to them if he agrees.
>> > > >
>> > > > Okay, we have two parts missing:
>> > > > - Nova Lake driver (I would need Alan or Mika to step in as at
>> > > > least a
>> > > > designated reviewer for that)
>> > >
>> > > I suggest Alan to be the reviewer if that's okay for him :)
>> >
>> > If he agrees, he can provide a patch on top of my series to move Nova
>> > Lake and add himself to the MAINTAINERS at the same time.
>>
>> I agree to be the reviewer. I have the patch ready, I can send once
>> your series is applied.
>
> Just send it now, in any case my series is blocked as I have not seen
> a consensus on what to do. Or do we? Bart, Sakari?
>

If I didn't make myself clear: I would love it if there was a single source
of intel GPIO pull-requests (most likely Andy) for *all* intel GPIO drivers
even if they have additional reviewers. I'd also love for them to live in
a single subdirectory at drivers/gpio/intel/. Otherwise, it's still chaos like
right now, just worse.

This is in line with pinctrl vendor directories. I also don't see a reason for
moving Kconfig options into their own vendor submenus if we keep the top-level
entries sorted by driver type.

Bart