Re: [PATCH] phy: core: Use EOPNOTSUPP for disabled blob return value

[Damien Le Moal]

On 2026/09/29 10:47, Inochi Amaoto wrote:
> Currently, the phy subsystem uses ENOSYS for dummy blob functions,
> it does not reflect the function state correctly. As kernel already

s/function state/hardware capability ?

s/As kernel/As the kernel

> has EOPNOTSUPP for disabled blob function, replace ENOSYS with

What is "blob function" ? Are you talking about all the phy_xxx() functions?

> EOPNOTSUPP for a clear return value. Also adapt the return value
> changed in the following affect file:

s/affect/affected

> - ata/libahci_platform.c
> - drm/bridge/analogix/analogix_dp_core.c
> - usb/dwc2/platform.c
> - usb/dwc3/core.c
> 
> Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx>

The ata bits looks OK, but this still feels like a lot of churn for no
functional change since the error is an internal one that is not exposed to the
user, as far as I can tell. The code in many places also uses -ENODEV, so the
error returned does not seem to be consistent anyway.

-- 
Damien Le Moal
Western Digital Research