Re: [RFC PATCH v7 3/4] blk-iocost: add iocost_ioc_tick tracepoint for per-period device summary
From: Tao Cui
Date: Tue Sep 29 2026 - 09:52:44 EST
Hello, Tejun.
在 2026/9/29 08:42, Tejun Heo 写道:
> Hello, Tao.
>
> On Thu, 24 Sep 2026 13:45:48 +0800, Tao Cui wrote:
>
>> + trace_iocost_ioc_tick(ioc, nr_active, usage_us_sum,
>> + ioc->period_us, ioc->vtime_base_rate,
>> + ioc->busy_level, ioc->running,
>> + now.now - ioc->period_at);
>
> These are still passed in. Can you pass only ioc, &now, nr_active and
> usage_us_sum and read the rest from ioc in TP_fast_assign() like the
> other iocost events do?
>
Done. The event now takes only ioc, &now, nr_active and
usage_us_sum. TP_fast_assign() reads period_us, vrate, busy_level
and running from ioc directly, and derives the elapsed period for
the usage percentage as now->now - ioc->period_at.
Thanks.
Tao> Thanks.
>
> --
> tejun