RE: [PATCH] mm/vma: avoid redundant file rmap tree re-insert on new_below=0 split

From: Deng, Pan

Date: Tue Sep 29 2026 - 09:56:18 EST


> >
> > I just saw Lorenzo has picked over this work in
> https://lore.kernel.org/all/20260925-speed-up-inplace-rmap-v1-1-
> babc48ce7c83@xxxxxxxxxx/. I've read through the new patch, which extends
> the scope to anonymous and covers merge and shrink scenario, more
> complete than I just sent, it is great. I fully agree that it is a very subtle and
> fragile part of the kernel, I did spend time and struggled with the patch, very
> appreciate your help.
>
> Thanks :) and thank you for your understanding.
>
> If you are able to test that locally with whatever workloads you've been using
> and report back there that'd be helpful? Thanks.

Reported back in that thread.

> >
> > One last thing, and please read it as a question rather than a request. I read
> submitting-patches.rst, and it says "Reported-by" tag is intended for bugs.
> While I wasn't reporting a bug, so would you consider "Suggested-by" instead
> (or even "co-developed-by") if you feel that describes it better? I'm fine with
> which tag you think is accurate, and I'm not trying to reopen the decision to
> take the work over. Again, very appreciate your review and looking forward to
> your help in the future.
>
> Yeah it's not quite the right match, but often the resultant final patch is
> quite substantially different than that submitted, and Suggested-by generally
> implies:
>
> Person X: 'hey I want to do ...'
> Person Y: 'have you thought of doing it using <great idea>'
> Person X: 'oh yeah great thanks will respin with that!'
>
> Whereas in this case where it seems it's end-to-end LLM, none of that really
> matches.

Oh, it is not end-to-end LLM, actually a lot of human intelligence is involved :)

> And if any tags are to be given then Reported-by, Closes is closest.
>
> However, since you're explicitly asking for it and the idea itself is nice, I'll
> ask Andrew to switch it out :)

Thanks a lot!

> (One small note - please wrap your lines to ~75 chars in emails makes life
> easier!)

Got it, will do!

Best Regards