Re: [PATCH v2] drm/ssd130x: Set the address window in ssd132x_clear_screen()

From: Javier Martinez Canillas

Date: Tue Sep 29 2026 - 10:28:29 EST


Fabio Piparo <holofermes@xxxxxxxxx> writes:

Hello Fabio,

> ssd132x_clear_screen() writes a full screen of data without setting
> the column and row ranges first, unlike ssd130x_clear_screen(). The
> clear is not reachable today: the plane disable returns before it,
> and the encoder is powered down by then.
>
> Factor the range commands into ssd132x_set_col_range() and
> ssd132x_set_row_range() and use them from ssd132x_update_rect() and
> ssd132x_clear_screen().
>
> Assisted-by: LLM
> Signed-off-by: Fabio Piparo <holofermes@xxxxxxxxx>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

I'll push to drm-misc (drm-misc-next). Thanks!

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat