Re: [PATCH] ASoC: codecs: wcd937x: use devm_free_irq() for watchdog IRQs

From: Mark Brown

Date: Tue Sep 29 2026 - 11:19:05 EST


On Tue, Sep 29, 2026 at 05:42:23PM +0800, Runyu Xiao wrote:
> The watchdog IRQs are requested with devm_request_threaded_irq() from the
> codec component probe, but the remove callback frees them with free_irq().
> The devres entries remain in place. Component teardown later tries to free
> the same IRQs again.

Surely the obvious thing here is that we shouldn't be using devm for the
interrupts in the first place, and/or should be moving to the driver
probe and not having to manually free them in the first place? This
isn't the right fix.

Attachment: signature.asc
Description: PGP signature