Re: [PATCH v5 3/3] arm64: dts: imx95: Add support for Data Modul i.MX95 eDM SBC

From: Marek Vasut

Date: Tue Sep 29 2026 - 11:33:10 EST

On 9/29/26 4:45 PM, Frank Li wrote:

Hello Frank,

+ backlight_lvds: backlight-lvds {
+ compatible = "pwm-backlight";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_panel_backlight_lvds>;
+ brightness-levels = <0 1 10 20 30 40 50 60 70 75 80 90 100>;
+ default-brightness-level = <7>;
+ enable-gpios = <&gpio2 27 GPIO_ACTIVE_HIGH>;
+ pwms = <&tpm3 3 5000000 0>;
+ /* Disabled by default, unless display board plugged in. */
+ status = "disabled";
+ };

The both backlight is not used in this dts, can you remove it and
add these when it real use.
It's the same thing we do on the other boards, so I would prefer to keep this consistent:

arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts: backlight: backlight {
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts: compatible = "pwm-backlight";
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts- brightness-levels = <0 1 10 20 30 40 50 60 70 75 80 90 100>;
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts- default-brightness-level = <7>;
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts- pwms = <&pwm1 0 5000000 0>;
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts- /* Disabled by default, unless display board plugged in. */
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts- status = "disabled";
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts- };