Re: [PATCH v2] crypto: ccp - Fix use-after-free in backlog cmd advancement

[Markus Elfring]

…
> +++ b/drivers/crypto/ccp/ccp-dev.c
> @@ -177,6 +177,15 @@ void ccp_del_device(struct ccp_device *ccp)
>  	write_unlock_irqrestore(&ccp_unit_lock, flags);
>  }
>  
> +/* Prevent promotion from waking an idle queue during teardown. */
> +void ccp_halt_cmds(struct ccp_device *ccp)
> +{
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&ccp->cmd_lock, flags);
> +	ccp->halting = true;
> +	spin_unlock_irqrestore(&ccp->cmd_lock, flags);
> +}
…

May lock guards be applied in affected function implementations?
https://elixir.bootlin.com/linux/v7.3-rc5/source/include/linux/spinlock.h#L642-L645

Regards,
Markus