Re: [PATCH 02/11] kselftest/arm64: Factor shared signal handlers out of fp-stress loads
From: Lorenzo Stoakes (ARM)
Date: Tue Sep 29 2026 - 12:09:02 EST
On Tue, Sep 01, 2026 at 06:06:42PM +0100, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
Nice cleanup! Yikes at that duplication.
Nit below but otherwise LGTM so:
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>
> diff --git a/tools/testing/selftests/arm64/fp/Makefile b/tools/testing/selftests/arm64/fp/Makefile
> index 183e9d319b65..d92a755837ff 100644
> --- a/tools/testing/selftests/arm64/fp/Makefile
> +++ b/tools/testing/selftests/arm64/fp/Makefile
> -ASM_UTILS := $(OUTPUT)/asm-utils.o $(OUTPUT)/asm-utils-linux.o
> +ASM_UTILS_LINUX := $(OUTPUT)/asm-utils.o $(OUTPUT)/asm-utils-linux.o
NIT: I wonder if it's worth renaming this ASM_UTILS_LINUX in the previous patch
to reduce the churn a bit?
--
Cheers, Lorenzo