Re: [PATCH] platform/x86: ideapad-laptop: Add PrintScreen key on ThinkBook 14 G8+ IPH

[Marco Giunta]

Hi Zekai,

Note that scancode 0x148 is already mapped in mainline: see commit
bc39af8c2c43 ("platform/x86: ideapad-laptop: Map Smart Connect hotkey to
KEY_LINK_PHONE"). Your patch seems to be based on an older tree.

That commit came from my two 2025 machines, a Yoga Pro 7 14ASP10 and a
Legion Pro 7 16AFR10H. On both, the F11 key shows a symbol with a laptop,
a tablet and a smartphone, and the user manual says it starts the Lenovo
Smart Connect app, so the event is mapped to KEY_LINK_PHONE.

I had a look at the ThinkBook 14 G8 user guide (I could not find the G8+
IPH variant specifically, though), and there F10 is the screenshot
selection tool, while F11 carries the same laptop/tablet/smartphone symbol
as on my machines.
Since your commit message describes the key as Fn+F11, I suspect
the event you recorded actually comes from the Smart Connect key rather
than from the screenshot selection tool key, in which case KEY_LINK_PHONE
is already what mainline reports for it.

In any case, if you do end up mapping a PrintScreen key in this driver,
note that KEY_SYSRQ is the magic SysRq key rather than a screenshot key;
KEY_PRINT, or KEY_SELECTIVE_SCREENSHOT as used for 0x04 and 0x2d if the
key opens a snipping tool, would seem more appropriate.

Best regards,
Marco