Re: [PATCH v12 2/2] pwm: rp1: Add RP1 PWM controller driver

[Gary Guo]

On Tue Sep 29, 2026 at 2:02 PM BST, Andrea della Porta wrote:
> From: Naushir Patuck <naush@xxxxxxxxxxxxxxx>
>
> The Raspberry Pi RP1 southbridge features an embedded PWM
> controller with 4 output channels, alongside an RPM interface
> to read the fan speed on the Raspberry Pi 5.
>
> Add the supporting driver.
>
> Signed-off-by: Naushir Patuck <naush@xxxxxxxxxxxxxxx>
> Co-developed-by: Stanimir Varbanov <svarbanov@xxxxxxx>
> Signed-off-by: Stanimir Varbanov <svarbanov@xxxxxxx>
> Co-developed-by: Andrea della Porta <andrea.porta@xxxxxxxx>
> Signed-off-by: Andrea della Porta <andrea.porta@xxxxxxxx>

At a quick glance the code looks alright to me.

Tested-by: Gary Guo <gary@xxxxxxxxxxx>

> ---
>  drivers/pwm/Kconfig   |   7 +
>  drivers/pwm/Makefile  |   1 +
>  drivers/pwm/pwm-rp1.c | 428 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 436 insertions(+)
>  create mode 100644 drivers/pwm/pwm-rp1.c
>