Re: [PATCH] scripts: run-clang-tools: import os for broken pipe handling
From: Nathan Chancellor
Date: Tue Sep 29 2026 - 16:23:30 EST
Hi Omer,
On Mon, Sep 28, 2026 at 07:47:14PM -0400, omer zalman wrote:
> The BrokenPipeError handler calls os.open() and os.dup2(), but the
> module never imports os. A broken output pipe therefore raises
> NameError while handling the original error. Import os so the
> handler can redirect stdout and exit as intended.
>
> Signed-off-by: Omer Zalman <omerzalman42@xxxxxxxxx>
>
> The exact git-format-patch file is attached because Gmail's web
> composer removes tabs from inline diffs.
As folks have mentioned on your other patches, you need to send your
patch using either git send-email or b4 so that they can be properly
handled by our tools, an attachment will not cut it.
Additionally, was this change inspired or developed by an LLM/agent? I
only ask because this has been broken for ages and you and another
person sent basically the same patch within a week of each other.
https://lore.kernel.org/179017337986.52388.7943687183785012868@xxxxxxxxx/
Odd coincidence if not. If so, please follow our coding assistants
documentation:
https://docs.kernel.org/process/coding-assistants.html
--
Cheers,
Nathan