Re: [PATCH] media: rkvdec: Remove redundant dev_err()

[Nicolas Dufresne]

Le samedi 19 septembre 2026 à 11:34 +0200, Diederik de Haas a écrit :
> The devm_request_threaded_irq() function already logs detailed error
> messages on failure automatically since commit
> 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()")
> So remove the now-redundant driver-specific dev_err() calls.
> 
> Signed-off-by: Diederik de Haas <diederik@xxxxxxxxxxxxxx>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>

> ---
>  drivers/media/platform/rockchip/rkvdec/rkvdec.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> index 061281f903f3..13d13c041509 100644
> --- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> +++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> @@ -1824,10 +1824,8 @@ static int rkvdec_probe(struct platform_device *pdev)
>  	ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
>  					rkvdec_irq_handler, IRQF_ONESHOT,
>  					dev_name(&pdev->dev), rkvdec);
> -	if (ret) {
> -		dev_err(&pdev->dev, "Could not request vdec IRQ\n");
> +	if (ret)
>  		return ret;
> -	}
>  
>  	rkvdec->sram_pool = of_gen_pool_get(pdev->dev.of_node, "sram", 0);
>  	if (!rkvdec->sram_pool && rkvdec->variant->num_rcb_sizes > 0)

Attachment: signature.asc
Description: This is a digitally signed message part