Re: [PATCH net v3 3/4] net: phy: serialise attach and detach with PHY driver bind and unbind

From: Jakub Kicinski

Date: Tue Sep 29 2026 - 20:47:50 EST


On Fri, 25 Sep 2026 00:59:49 +0300 Aleksei Sviridkin wrote:
> /**
> - * phy_probe - probe and init a PHY device
> + * __phy_probe - probe and init a PHY device
> * @dev: device to probe and init
> *
> * Take care of setting up the phy_device structure, set the state to READY.
> */
> -static int phy_probe(struct device *dev)
> +static int __phy_probe(struct device *dev)

You're touching it, you need to make the kdoc fully valid:

Warning: drivers/net/phy/phy_device.c:3709 No description found for return value of '__phy_probe'

> +static int __phy_probe(struct device *dev);

the forward declaration is unavoidable? we can't reorder?
--
pw-bot: cr