RE: [PATCH 1/2] ice: simplify ice_pf_state_is_nominal()
From: Nowlin, Alexander
Date: Tue Sep 29 2026 - 21:22:36 EST
> -----Original Message-----
> From: Yury Norov <ynorov@xxxxxxxxxx>
> Sent: Thursday, September 3, 2026 6:21 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; open list <linux-kernel@xxxxxxxxxxxxxxx>
> Cc: Yury Norov <ynorov@xxxxxxxxxx>
> Subject: [PATCH 1/2] ice: simplify ice_pf_state_is_nominal()
>
> The function creates a temporary mask on stack just to check that first ICE_STATE_NOMINAL_CHECK_BITS is empty. Simplify it by using the ice_pf_state_is_nominal().
>
> Signed-off-by: Yury Norov <ynorov@xxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/ice/ice_lib.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
Tested-by: Alexander Nowlin <alexander.nowlin@xxxxxxxxx>