RE: [PATCH v2 1/2] dt-bindings: watchdog: Add Exynos8855 watchdog compatible string

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Sunday, September 27, 2026 10:41 PM
> To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; peter.griffin@xxxxxxxxxx;
> robh@xxxxxxxxxx; conor+dt@xxxxxxxxxx; linusw@xxxxxxxxxx
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-watchdog@xxxxxxxxxxxxxxx; linux@roeck-
> us.net; hajun.sung@xxxxxxxxxxx; wim@xxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 1/2] dt-bindings: watchdog: Add Exynos8855
> watchdog compatible string
> 
> On 27/09/2026 17:27, Alim Akhtar wrote:
> > Add the 'samsung,exynos8855-wdt' compatible string to the Samsung
> > watchdog device tree binding documentation. The Exynos8855 watchdog
> > nodes use two clocks (bus clock and source clock), require
> > samsung,cluster-index and samsung,syscon-phandle properties, similar
> > to Exynos850 watchdog implementation.
> >
> > Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> > ---
> > * Changes in V2:
> >  - Fixed Sashiko review comment
> > 	- [Low] dt-bindings: watchdog: missing comma in
> > samsung,syscon-phandle description
> >
> >  Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml | 6
> > ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> > b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> > index a32c47831577..3f8c3e56ea07 100644
> > --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> > @@ -25,6 +25,7 @@ properties:
> >            - samsung,exynos5515-wdt
> >            - samsung,exynos7-wdt                   # for Exynos7
> >            - samsung,exynos850-wdt                 # for Exynos850
> > +          - samsung,exynos8855-wdt                # for Exynos8855
> 
> 
> Just drop the comment like we did for 5515.
> 
Sure, will update in next version

> Reviewed-by: Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> 
Thanks for your review. 

> Best regards,
> Krzysztof