Re: [PATCH 2/3] staging: iio: accel: adis16203: add missing spi_device_id table

[Joshua Crofts]

On Tue, 29 Sep 2026 21:48:59 +0300
Abdelnasser Hussein <abdelnasserhussein11@xxxxxxxxx> wrote:

> The driver currently relies on OF/DT matching but lacks an SPI device
> ID table. This prevents module auto-loading on systems without device
> tree support.
> 
> Add the spi_device_id table to resolve this and ensure the driver loads
> properly across all supported platforms.
> 
> Signed-off-by: Abdelnasser Hussein <abdelnasserhussein11@xxxxxxxxx>
> ---
>  drivers/staging/iio/accel/adis16203.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
> index eddb786d4747..905485fd556f 100644
> --- a/drivers/staging/iio/accel/adis16203.c
> +++ b/drivers/staging/iio/accel/adis16203.c
> @@ -11,6 +11,7 @@
>  #include <linux/iio/imu/adis.h>
>  
>  #include <linux/kernel.h>
> +#include <linux/mod_devicetable.h>

No need for mod_devicetable.h, this is imported using spi.h

>  #include <linux/module.h>
>  #include <linux/spi/spi.h>
>  
> @@ -292,12 +293,19 @@ static const struct of_device_id adis16203_of_match[] = {
>  
>  MODULE_DEVICE_TABLE(of, adis16203_of_match);
>  
> +static const struct spi_device_id adis16203_id[] = {
> +	{ "adis16203", 0 },

C99 initializers please.

> +	{ }
> +};
> +MODULE_DEVICE_TABLE(spi, adis16203_id);
> +
>  static struct spi_driver adis16203_driver = {
>  	.driver = {
>  		.name = "adis16203",
>  		.of_match_table = adis16203_of_match,
>  	},
>  	.probe = adis16203_probe,
> +	.id_table = adis16203_id,
>  };
>  module_spi_driver(adis16203_driver);
>  

Additionally, you should delete the MODULE_ALIAS("spi:adis16203") line.

-- 
Kind regards,
Joshua Crofts