Re: [PATCH] x86/apic/msi: Fix MSI interrupt affinity configuration

[WeitaoWang-oc]

On 9/30/26 00:29, Koichiro Den wrote:
> On Tue, Sep 29, 2026 at 12:48:39AM +0800, WeitaoWang-oc wrote:
> > commit b56ebe7c896d ("x86/apic/msi: Fix misconfigured non-maskable MSI
> > quirk") try to fix the issue of misconfigured non-maskable MSI quirk.
> > For non-maskable MSI interrupts, use the slow path to fix the MSI affinity
> > race. Maskable MSI interrupts use the direct path to update configuration
> > info. However, the current code logic is the opposite as only maskable
> > MSI interrupts will enable reservation mode.
>
> Hi Weitao, thanks for catching this.
>
> > Fixes: ef8dd01538ea ("genirq/msi: Make interrupt allocation less convoluted")
>
> I'd rather (or also) add:
>
>    Fixes: b56ebe7c896d ("x86/apic/msi: Fix misconfigured non-maskable MSI quirk")
>
> As I recall, I started out trying to fix the issue, but then got too focused on
> removing the flag. I missed that the check needed to be inverted. This
> left the race unfixed and also made maskable interrupts possibly take the slow
> path unnecessarily. Sorry for the trouble. Feel free to use this if it helps:
>
>    Reviewed-by: Koichiro Den <den@xxxxxxxxxxxxx>
>
> Best regards,
> Koichiro

Hi Koichiro,

Thank you four suggestion and review. I'll send a v2 patch.

Best Regards,
Weitao