Re: [PATCH v4 2/3] KVM: arm64: Block ID register changes after we rely on the values

From: Marc Zyngier

Date: Wed Sep 30 2026 - 04:23:11 EST


On Tue, 29 Sep 2026 12:57:59 +0100,
Mark Brown <broonie@xxxxxxxxxx> wrote:

[...]

> +#define kvm_id_regs_final(kvm) \
> + test_bit(KVM_ARCH_FLAG_ID_REGS_FINAL, &(kvm)->arch.flags)
> +
> +#define vcpu_id_regs_final(vcpu) \
> + kvm_id_regs_final((vcpu)->kvm)
> +

This second helper really gives the wrong idea (idregs are never
vcpu-specific with KVM). I've dropped it when applying this series.

Thanks,

M.

--
Without deviation from the norm, progress is not possible.