Re: [PATCH v3 0/5] sh: mach-rsk: rsk7203: switch to using static device property, drop legacy gpio API
From: Andy Shevchenko
Date: Wed Sep 30 2026 - 04:37:22 EST
On Wed, Sep 30, 2026 at 09:23:21AM +0200, Arnd Bergmann wrote:
> On Wed, Sep 30, 2026, at 06:57, Dmitry Torokhov wrote:
> > This series of patches converts rsk7203 to use static device properties
> > for its devices, including gpio-keys and gpio-leds, and removing
> > dependency on legacy gpio API (in favor of gpiod API).
>
> The patches look good to me. I have build-tested this with the snippet
> below and my series from
> https://lore.kernel.org/all/20260907090956.2825703-2-arnd@xxxxxxxxxx/
> to check that no use of the legacy interfaces remain.
> You can probably fold my one-liner into your last patch.
>
> There is a trivial conflict between your series and my patch 2/2
> "gpiolib: remove linux/gpio.h", but if yours gets merged, I can
> resend mine without that line.
>
> > To configure pin functions the board is switched to use gpio-hogs, as
> > doing full conversion to pinmux is too challenging without access to
> > hardware.
>
> I would guess even with access to hardware testing is going to be
> challenging, I noticed that the defconfig kernel does not fit on the
> 4MB flash any more (even without rootfs), and the USB support was
> never added for rsk7203, only for 7264/7269.
...which induces a practical question, shouldn't we just drop the whole thing
for good?
--
With Best Regards,
Andy Shevchenko