Re: [PATCH v2 07/14] iio: adc: stm32-adc: add support for stm32mp25

[Fabrice Gasnier]

On 9/30/26 10:33, Andy Shevchenko wrote:
> On Tue, Sep 29, 2026 at 06:48:28PM +0200, Fabrice Gasnier wrote:
>> On 9/24/26 23:01, Andy Shevchenko wrote:
>>> On Wed, Sep 23, 2026 at 05:39:10PM +0200, Fabrice Gasnier wrote:
> 
> ...
> 
>>>>  		.compatible = "st,stm32mp13-adc-core",
>>>>  		.data = (void *)&stm32mp13_adc_priv_cfg
>>>>  	}, {
>>>> -	},
>>>> +		.compatible = "st,stm32mp25-adc-core",
>>>> +		.data = (void *)&stm32mp25_adc_priv_cfg
>>>> +	}, {
>>>> +	}
>>>
>>> Same issue and now it's a regression from maintenance perspective: you added an
>>> unnedeed churn that has to be handled from now on... TL;DR: do add trailing
>>> commas to the non-terminator entries and remove trailing commas in the
>>> terminator entries.
> 
>> Do you wish I add a separate cleanup patch for existing match table ?
>> This can also fit into 100 chars line now:
> 
> This is, of course, is up to you, but my comment was solely against the
> trailing comma removal.
> 
>> static const struct of_device_id stm32_adc_of_match[] = {
>> 	{ .compatible = "st,stm32f4-adc-core", .data = (void
>> *)&stm32f4_adc_priv_cfg, },
> 
> Here is actually the opposite, no inner trailing comma should be added as it's
> a one-line entry.

Hi Andy,

Sorry if I'm a bit confused :-), just to be sure, the preferred style should be as below ?

static const struct of_device_id stm32_adc_of_match[] = {
	{ .compatible = "st,stm32f4-adc-core", .data = (void *)&stm32f4_adc_priv_cfg },
	{ .compatible = "st,stm32h7-adc-core", .data = (void *)&stm32h7_adc_priv_cfg },
	{ .compatible = "st,stm32mp1-adc-core",	.data = (void *)&stm32mp1_adc_priv_cfg },
	{ .compatible = "st,stm32mp13-adc-core", .data = (void *)&stm32mp13_adc_priv_cfg },
	{ }
};

Thanks,
Best Regards,
Fabrice
> 
>> 	{ .compatible = "st,stm32h7-adc-core", .data = (void
>> *)&stm32h7_adc_priv_cfg, },
>> 	{ .compatible = "st,stm32mp1-adc-core",	.data = (void
>> *)&stm32mp1_adc_priv_cfg, },
>> 	{ .compatible = "st,stm32mp13-adc-core", .data = (void
>> *)&stm32mp13_adc_priv_cfg, },
>> 	{ }
>> };
> 
>>>>  };
>