Re: [PATCH v5 2/2] staging: media: atomisp: Remove dbg_level and dbg_func module parameters

[Andy Shevchenko]

On Wed, Jul 22, 2026 at 11:16:15AM +0530, Prajval Chaudhary wrote:
> Remove the 'dbg_level' and 'dbg_func' module parameters to align the
> driver's debug logging with standard Linux kernel printk infrastructure.
> 
> Previously:
> - 'dbg_level' controlled trace verbosity level (default 0, up to 9).
> - 'dbg_func' selected whether CSS trace outputs routed to printk (1)
>   or remained disabled/unrouted (0).
> 
> Since module-level custom parameters duplicate modern dynamic debug and
> printk capabilities, remove them and filter trace messages in
> ia_css_debug_vdtrace() to IA_CSS_DEBUG_WARNING or lower.

...

>  unsigned int ia_css_debug_get_dtrace_level(void)
>  {
> -	return dbg_level;
> +	return 0;
>  }

I believe this changes the flexibility of the tracing. But like I said, the
whole infrastructure should be switched to use trace events and trace points.

-- 
With Best Regards,
Andy Shevchenko