Re: [PATCH v2] arm64: dts: qcom: shikra-evk: Add GPIO expanders

[Konrad Dybcio]

On 9/29/26 10:35 AM, Komal Bajaj wrote:
> Add the EVK GPIO expander definitions on the I2C3 bus. Describe the
> TCA9538 and TCA9539 expanders used by EVK boards.
> 
> Co-developed-by: Faruque Ansari <faruque.ansari@xxxxxxxxxxxxxxxx>
> Signed-off-by: Faruque Ansari <faruque.ansari@xxxxxxxxxxxxxxxx>
> Signed-off-by: Komal Bajaj <komal.bajaj@xxxxxxxxxxxxxxxx>
> ---

[...]

> +&i2c3 {
> +	status = "okay";
> +
> +	expander0: pca953x@38 {
> +		compatible = "ti,tca9538";
> +		reg = <0x38>;
> +		#gpio-cells = <2>;
> +		gpio-controller;
> +	};

Please keep the nodes sorted by their unit address

Konrad
 > +
> +	expander1: pca953x@3c {
> +		compatible = "ti,tca9538";
> +		reg = <0x3c>;
> +		#gpio-cells = <2>;
> +		gpio-controller;
> +	};
> +
> +	expander2: pca953x@20 {
> +		compatible = "ti,tca9539";
> +		reg = <0x20>;
> +		#gpio-cells = <2>;
> +		gpio-controller;
> +	};
> +
> +	expander3: pca953x@21 {
> +		compatible = "ti,tca9539";
> +		reg = <0x21>;
> +		#gpio-cells = <2>;
> +		gpio-controller;
> +	};
> +};
> +
>  &qupv3_0 {
>  	firmware-name = "qcom/shikra/qupv3fw.elf";
>  
> 
> ---
> base-commit: 6375e61c01e93e35ee7acd336a689ac1fae4b509
> change-id: 20260924-shikra-gpio-expander-25ff4a29c848
> 
> Best regards,