Re: [PATCH v4 1/3] dt-bindings: edac: cdns,ddr-edac: add Cadence DDR EDAC binding
From: Krzysztof Kozlowski
Date: Wed Sep 30 2026 - 06:43:01 EST
On Tue, Sep 29, 2026 at 11:18:26AM +0200, Miquel Raynal wrote:
> Hi Krzysztof,
>
> >> +properties:
> >> + compatible:
> >> + items:
> >> + - const: renesas,r9a06g032-ddr-edac # RZ/N1D
> >> + - const: cdns,ddr-edac
> >
> > I doubt this can be used standalone, so I am not sure what is the
> > benefit of cnds compatible.
>
> For now it seems that we are not using any Renesas specific
> implementation detail. The driver actually matches the Cadence
> compatible. But since we have no other user, and since we know this IP
> is generic, we preferred to add a Renesas compatible to match the actual
> implementation of the Cadence IP, in case we later figure out
> differences with the original HDL. I thought this was the correct policy
> to apply.
Indeed I don't see Renesas-specific quirks in the driver. I think having
a generic vendor-block compatible is not a preferred policy in general,
because in the past many times it was simply not enough, so was actually
useless. I guess fine here.
Best regards,
Krzysztof