Re: [PATCH v2 1/4] dt-bindings: ufs: Add nvidia,tegra264-ufs
From: Krzysztof Kozlowski
Date: Wed Sep 30 2026 - 06:46:40 EST
On 30/09/2026 12:43, Krzysztof Kozlowski wrote:
> On Tue, Sep 29, 2026 at 03:15:07PM +0530, Kartik Rajput wrote:
>> Add binding for the UFS host controller on NVIDIA Tegra264 SoCs. The
>> controller supports UFS 3.1 up to HS-G4B on two data lanes.
>>
>> Signed-off-by: Kartik Rajput <kkartik@xxxxxxxxxx>
>
> I do not understand why you added dependency on the phy in this
> patchset. Looks like fake/not real dependency, so you only stall your
> work and raise questions.
>
> Cover letter mentions "the binding references
> the M-PHY provider" but this is simply NOT TRUE.
>
> Patch itself is correct but I suggest to be careful what you send, to
> avoid questions on trivial stuff.
Forgot the tag:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
But honestly, this fake dependency is a no-go and I commented on driver
patch regarding it.
Best regards,
Krzysztof