Re: [PATCH v2 4/4] scsi: ufs: tegra: Add Tegra264 UFS host controller driver

[Krzysztof Kozlowski]

On Tue, Sep 29, 2026 at 03:15:10PM +0530, Kartik Rajput wrote:
> Add a driver for the UFS host controller found on NVIDIA Tegra264 SoCs.
> The controller has Tegra-specific auxiliary registers, clocks and resets,
> and it drives the four M-PHY lane directions exposed by the Tegra264
> M-PHY driver.
> 
> Co-developed-by: Thierry Reding <treding@xxxxxxxxxx>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> Signed-off-by: Kartik Rajput <kkartik@xxxxxxxxxx>
> ---
>  drivers/ufs/host/Kconfig     |  14 +
>  drivers/ufs/host/Makefile    |   1 +
>  drivers/ufs/host/ufs-tegra.c | 686 +++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 701 insertions(+)
> 
> diff --git a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig
> index ff170c0b6da0..7ca317d25251 100644
> --- a/drivers/ufs/host/Kconfig
> +++ b/drivers/ufs/host/Kconfig
> @@ -168,3 +168,17 @@ config SCSI_UFS_AMD_VERSAL2
>  
>  	  Select this if you have UFS controller on AMD Versal Gen 2 SoC.
>  	  If unsure, say N.
> +
> +config SCSI_UFS_TEGRA
> +	tristate "NVIDIA Tegra264 UFS controller platform driver"
> +	depends on SCSI_UFSHCD_PLATFORM
> +	depends on ARCH_TEGRA_264_SOC || (COMPILE_TEST && 64BIT)
> +	select PHY_TEGRA_MPHY

Nope.

There is nothing here which depends on the phy. If there is, you wrote
this wrong and did not use proper Linux interfaces (the Generic PHY).

Also, you must NOT select user-visible symbols, that's basic rules now.

Best regards,
Krzysztof