Re: [PATCH v5 2/9] dt-bindings: clock: ma35d1: Document the missing crystal inputs

From: Krzysztof Kozlowski

Date: Wed Sep 30 2026 - 08:02:34 EST


On Tue, Sep 29, 2026 at 04:44:45PM +0200, Miquel Raynal wrote:
> The MA35D1 clock controller takes two crystal oscillator inputs from
> the board:
> - HXT, a high-speed 24 MHz crystal for most of the system
> - LXT, a low-speed 32.768 kHz crytal for the RTC and low power modes
>
> So far the binding was expecting a single crystal. The example named it
> HXT, but no real definition for it was given. LXT was not even
> described. In order to remain backward compatible, we will continue to
> allow either one (HXT) or two (HXT then LXT) input clocks. I propose to
> give those phandles a name to clarify what these entries expect, but I'm
> not listing the clock-names property in the required block, for backward
> compatibility. The rates are fixed by the TRM, so even if the second
> oscillator is not described, the OS can make an educated guess.
>
> Fixes: 2f8b5eb589cb ("dt-bindings: clock: nuvoton: add binding for ma35d1 clock controller")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof