Re: [PATCH v3 08/13] dt-bindings: iio: adc: adi,ad4134: Document SPI connection mode
From: Rob Herring (Arm)
Date: Wed Sep 30 2026 - 08:02:35 EST
On Tue, 29 Sep 2026 19:44:22 -0300, Marcelo Schmitt wrote:
> Document how AD4134 chips are connected to the host SPI controller
> according to different wiring configurations.
>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>
> ---
> Change log v2 -> v3:
> - Adjusted spi-rx-bus-width constraints.
>
> Unfortunately, I missed SPI connection mode properties when introducing AD4134
> dt-doc and the device driver defaulted to a no-CS configuration. Due to that,
> conventional 4-wire mode can't be made default without leading to a regression.
> Still, updating the SPI mode default to 4-wire is a sensible thing to do later
> on if acceptable.
>
> .../bindings/iio/adc/adi,ad4134.yaml | 51 ++++++++++++++++---
> 1 file changed, 44 insertions(+), 7 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml:174:24: [warning] too few spaces after comma (commas)
./Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml:180:24: [warning] too few spaces after comma (commas)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/12e5af9d96f6c5e800ad860d3cfa6ac8006a22e2.1790719425.git.marcelo.schmitt@xxxxxxxxxx
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.