Re: [PATCH 4/8] watchdog: core: Stop pretimeout hrtimer on suspend

[Tzung-Bi Shih]

On Tue, Sep 29, 2026 at 06:46:31AM -0700, Guenter Roeck wrote:
> During system suspend, watchdog_dev_suspend() pings the watchdog (which
> restarts the software pretimeout hrtimer) and stops the keepalive ping
> worker, but fails to stop the pretimeout hrtimer. Because
> CLOCK_MONOTONIC continues ticking until the system fully suspends, a
> suspend process taking longer than the configured pretimeout will
> trigger a spurious pretimeout event.
> 
> Stop the pretimeout hrtimer in watchdog_dev_suspend(), prevent
> watchdog_hrtimer_pretimeout_start() from starting it while the watchdog
> is suspended, and restart it in watchdog_dev_resume() if the hardware
> watchdog is running.
> 
> Fixes: 60bcd91aafd2 ("watchdog: introduce watchdog_dev_suspend/resume")
> Assisted-by: LLM
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>