Re: [PATCH] media: exynos4-is: Fix runtime PM usage counter leak in fimc-isp

From: Krzysztof Kozlowski

Date: Wed Sep 30 2026 - 08:15:13 EST


On 30/09/2026 13:38, fengchenguang@xxxxxxxxxx wrote:
> From: Chenguang Feng <fengchenguang@xxxxxxxxxx>
>
> fimc_isp_subdev_s_power() increments the usage counter with
> pm_runtime_resume_and_get() and releases it if fimc_is_start_firmware()
> fails, but not when fimc_is_hw_initialize() fails further down: the
> function then returns with the counter still held, and the device can
> never runtime-suspend afterwards.
>
> Call pm_runtime_put() on the fimc_is_hw_initialize() error path as
> well, like the fimc_is_start_firmware() path already does.
>
> Fixes: 9a761e436843f ("[media] exynos4-is: Add Exynos4x12 FIMC-IS driver")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Chenguang Feng <fengchenguang@xxxxxxxxxx>
> ---


How many separate patches are you planning to send? Why this cannot be a
patchset? Are we repeating now the recent half-spam of AI created "fixes"?

Best regards,
Krzysztof