Re: [PATCH 5/8] watchdog: core: Restore WDOG_HW_RUNNING if stopping watchdog fails

[Guenter Roeck]

On Wed, Sep 30, 2026 at 07:54:20PM +0800, Tzung-Bi Shih wrote:
> On Tue, Sep 29, 2026 at 06:46:32AM -0700, Guenter Roeck wrote:
> > diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
> > index af756ee228b2..edf2cccd1c0e 100644
> > --- a/drivers/watchdog/watchdog_dev.c
> > +++ b/drivers/watchdog/watchdog_dev.c
> > @@ -324,6 +324,8 @@ static int watchdog_stop(struct watchdog_device *wdd)
> >  		clear_bit(WDOG_ACTIVE, &wdd->status);
> >  		watchdog_update_worker(wdd);
> >  		watchdog_hrtimer_pretimeout_stop(wdd);
> > +	} else {
> > +		set_bit(WDOG_HW_RUNNING, &wdd->status);
> >  	}
> 
> This makes more sense to me to move into the block introduced by [1].

Definitely. Thanks!

Guenter